F0095 stk-5¶
Rule: Big state is built in place, not by value and moved into a static.
| Code | F0095 (stable, never reused) |
| Id | stk-5 |
| Category | stk |
| Source | spirit_level |
| Fix | by hand |
| Needs | the firmware's linked ELF (--elf); skipped without a firmware binary |
Level per tier¶
| Tier | Level | Reason |
|---|---|---|
| small | off | |
| small-workspace | off | |
| medium | off | |
| big | off | |
| ai | off | |
| embedded | warn |
bedrock warning: Big state built by value and moved into a static (StaticCell::init(Big::new())): the frame holds it whole; build it in place (const fn new, init into MaybeUninit) |
| ui | off | |
| egui | off | |
| units-strict | off | |
| units-paranoid | off |
Parameters¶
| Name | Type | Default | Meaning |
|---|---|---|---|
move-frame |
integer | 1024 |
bytes of frame from which a function that moves a value into a static is reported |
Why¶
A large struct constructed on the stack (Big::new()) and then moved whole into a StaticCell::init(...), instead of being built directly inside the static's storage.
Rust doesn't guarantee the move is elided; the calling function's stack frame has to hold the whole value, sized as if the static didn't exist, right at the moment it's about to be thrown away. On a task that's already close to its stack budget this can be the difference between fitting and overflowing, and it only shows up as a size the task takes just before handing the data off.
Example¶
Wire_weaver's ObserveBatches: a 31.6 KB stack frame on M4F, entirely from building the value before moving it into its static.
How to fix¶
Build the state in place: a const fn new() plus MaybeUninit-based initialisation directly inside the static's storage, so no full copy ever exists on the stack.
How it is checked¶
src mid (spot the by-value construction pattern) plus elf mid (confirm the frame size in the linked ELF) — both halves needed to tell a real problem from a value the compiler already elided.
Source¶
Ported from embedded_bedrock's firmware check catalogue, STK-5 (book/checks.md, detail in book/checks/stk.md). Found on: wire_weaver ObserveBatches: 31.6 KB frame on M4F.
Configure¶
Allow one finding in the code with // spirit-level: allow(stk-5) <reason> (waivers); the code works there too, as in [lints.F0095].